I am trying to optimise how a msg is constructed. This is what I have: if (counter == 0) { msg = { payload: "OFF", icon: '', background: "black" }; } else { …

[image] msg = { ... } // literally means "Create a NEW object"

Where does counter come from? [image] Trying_to_learn: It doesn't work. because you set payload then destroy the original msg by doing this... msg = { icon: '', background: "black" }; Why not do thi…

[image] Steve-Mcl: because you set payload then destroy the original msg by doing this... msg = { icon: '', background: "black" }; I don't see how that overwrites the original payload part of the mess…

[image] Trying_to_learn: Isn't your second way the same as my second way? No You destroy the original msg every time - I reuse it (as is the preferred way as far as I am concerned)

Yeah, ok. So the { } were my undoing. Thanks.

Or shorter version payload = counter === 0 ? "OFF" : "ON" msg.icon = ''; msg.background = "black"; msg.payload = payload return msg

Dont be throwing ternary confusion into the mix man :smiley:

You're just showing off now @bakman2 :wink:

msg.icon = ''; msg.background = "black"; msg.payload = counter === 0 ? "OFF" : "ON"; return msg Shorter @bakman2 :wink:

PS, your ternary is wrong way around :wink:

Node-RED

Node-RED Forum

(Brain failure) Need help understanding why it isn't working

General

Trying_to_learn 21 July 2020 07:04 3

Counter is set earlier on.

Isn't your second way the same as my second way?

I need a good slapping to get the brain working.

Topic		Replies	Views
Tips on streamlining this function General	22	632	20 November 2020
Help how to change the icon depending on value General	18	193	24 September 2024
Change node propery from directly from "function" General	20	853	22 August 2021
Multiple outputs of function node not working General	28	5416	4 August 2019
Question: Optimize msg traffic General	11	300	6 January 2023

Copyright OpenJS Foundation and Node-RED contributors. All rights reserved. The OpenJS Foundation has registered trademarks and uses trademarks. For a list of trademarks of the OpenJS Foundation, please see our Trademark Policy and Trademark List. Trademarks and logos not indicated on the list of OpenJS Foundation trademarks are trademarks™ or registered® trademarks of their respective holders. Use of them does not imply any affiliation with or endorsement by them.

(Brain failure) Need help understanding why it isn't working

Related topics