# Deploy button enabled after no change edit of node

**URL:** <https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157>\
**Category:** General\
**Created:** [10 January 2020 10:15 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157 "2020-01-10T10:15:12Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![MaxS](https://avatars.discourse-cdn.com/v4/letter/m/96bed5/32.png) [@MaxS](https://discourse.nodered.org/u/MaxS)\
**Post date:** [10 January 2020 10:15 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/1 "2020-01-10T10:15:12Z")

</div>

If you have a node with a config node as a property (for example Websocket in). If you don't give the config node field a value (leave it empty, or don't create a config node) when you press done and deploy, and then open the edit dialog again and press done, the deploy button will be enabled even if you didn't change anything. This is the case even when the property isn't required.

As this only happens for config node properties and not for other properties it seem a bit strange. Is there a reason behind it?

---

<div class="post-metadata">

**Author:** ![zenofmud](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/zenofmud/32/316_2.png) [@zenofmud](https://discourse.nodered.org/u/zenofmud)\
**Post date:** [10 January 2020 11:14 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/2 "2020-01-10T11:14:45Z")

</div>

It's possible that the node fills in a default value and saves it causing a change that triggers the Deploy to enable.

---

<div class="post-metadata">

**Author:** ![MaxS](https://avatars.discourse-cdn.com/v4/letter/m/96bed5/32.png) [@MaxS](https://discourse.nodered.org/u/MaxS)\
**Post date:** [10 January 2020 11:50 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/3 "2020-01-10T11:50:56Z")

</div>

If you don't already have a config node I don't think it does. You can also deploy, open edit, press done again and deploy still shows up. If it put a default value it wouldn't happen a second time, right?

---

<div class="post-metadata">

**Author:** ![knolleary](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/knolleary/32/3_2.png) [@knolleary](https://discourse.nodered.org/u/knolleary)\
**Post date:** [10 January 2020 14:13 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/4 "2020-01-10T14:13:11Z")

</div>

If you edit a node that depends on a config node but the node doesn't currently have a config node set, it will automatically select the first config node in the list - if there is one. So whilst you may not have changed anything manually, something will have changed.

You can confirm this by clicking the 'show more' link in the Info sidebar when you have the node selected. That will show its full configuration. Edit the done, close the dialog and then see what has changed.

---

<div class="post-metadata">

**Author:** ![MaxS](https://avatars.discourse-cdn.com/v4/letter/m/96bed5/32.png) [@MaxS](https://discourse.nodered.org/u/MaxS)\
**Post date:** [10 January 2020 14:19 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/5 "2020-01-10T14:19:50Z")

</div>

I have deleted all config nodes and the problem still occur. So it's not choosing a node from the list.

I tried looking at show more for the Websocket in and the value is undefined both before and after.

---

<div class="post-metadata">

**Author:** ![knolleary](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/knolleary/32/3_2.png) [@knolleary](https://discourse.nodered.org/u/knolleary)\
**Post date:** [10 January 2020 14:53 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/6 "2020-01-10T14:53:15Z")

</div>

Hi @MaxS

I have recreated this and it is a subtle bug in the change detection when config nodes are in play. Thanks for highlighting - I've pushed a fix, will be in the next release, whenever that may happen.

---

<div class="post-metadata">

**Author:** ![MaxS](https://avatars.discourse-cdn.com/v4/letter/m/96bed5/32.png) [@MaxS](https://discourse.nodered.org/u/MaxS)\
**Post date:** [10 January 2020 15:25 UTC](https://discourse.nodered.org/t/deploy-button-enabled-after-no-change-edit-of-node/20157/7 "2020-01-10T15:25:28Z")

</div>

Hi @knolleary

Great, thanks! I suspected it might be a bug but was uncertain if there was a valid reason for the behaviour.