How to convert to a function

gbond · 28 December 2018 23:43

that is ok when ever you r able to will be fine sorry its beyond me at the moment but what I have so far is great

so much easier to play around with the timings

meeki007 · 28 December 2018 23:43

I'm just looking for a pointer. Not looking for you to fix it knolleary. here is where im at.

//get the values of msg.* to var's
var numberofblinks = msg.numberofblinks;
var light_on_for_ms = msg.lighton;
var light_off_for_ms = msg.lightoff;
//var run;

//how long to wait before starting the light show
var time_in_ms_to_wait_before_first_execution = 1000;

//total run time of light on and light off
var time_in_ms_to_wait_between_recursive_setTimeout = (light_on_for_ms + light_off_for_ms);

//set the count to 0
var count = 1;

//function to count the number of blinks and stop timmer
function blinks()
{
    if (numberofblinks < count)
    {
        //stop the recursive setTimeout
        clearTimeout(tostopit);
    
    }
    else
    {
        count++;
    }
}



//function to set payload to true
function payload_true()
{
    //set payload to true
    node.send({payload:true});
    
    //display green dot when light is on
    node.status({
                    fill: 'green',
                    shape: 'dot',
                    text: ' '
                });
}

//function to set payload to false
function payload_false()
{
    //set payload to false
    node.send({payload:false});
    
    //clear status when payload false
    node.status({
            });
}


//run the light show!!!!
setTimeout(function run() 
{
    blinks();
    //turn the light on by setting msg.payload to true
    payload_true();
    
    //turn the light off by waiting to set the payload to false by the ammount of time light is on
    setTimeout(payload_false, light_on_for_ms);
    //i++;
    
    //total ammount of time light can be on or off before it runs again
    var tostopit = setTimeout(run, time_in_ms_to_wait_between_recursive_setTimeout);
}, time_in_ms_to_wait_before_first_execution);


return msg;

it now gives me "ReferenceError: tostopit is not defined" so im poking at the right spot

dceejay · 28 December 2018 23:43

Again from a phone. But you need

clearTimeout(tostopit);

IE clear the reference to the timer that you created for

gbond · 28 December 2018 23:46

little example of how I am using this so far (so much tider)

knolleary · 28 December 2018 23:58

You define tostopit inside the run function, so it isn't in scope at the point you call clearTimeout.

Stick var tostopit; at the top of the function and remove the var keyword where you set it's value inside the run function.

meeki007 · 29 December 2018 00:01

Good Idea: I've done that.......Just did it again .......
It runs forever without stopping

I think i need to sleep on it

cflurin · 29 December 2018 09:22

Move blinks() to the end of the setTimeout(function run()

//run the light show!!!!
setTimeout(function run() 
{
    //turn the light on by setting msg.payload to true
    payload_true();
    
    //turn the light off by waiting to set the payload to false by the ammount of time light is on
    setTimeout(payload_false, light_on_for_ms);
    
    //total ammount of time light can be on or off before it runs again
    tostopit = setTimeout(run, time_in_ms_to_wait_between_recursive_setTimeout);
    
    blinks();
    
}, time_in_ms_to_wait_before_first_execution);

gbond · 29 December 2018 12:28

this has got rid off the error,
but if i run it once looks ok
but second time the light stays switch on to start with and stays on longer than it should before starting to flash (dont get the exactly same sequence each time)

gbond · 29 December 2018 12:35

//get the values of msg.* to var's
var numberofblinks = msg.numberofblinks;
var light_on_for_ms = msg.lighton;
var light_off_for_ms = msg.lightoff;
//var run;

//how long to wait before starting the light show
var time_in_ms_to_wait_before_first_execution = 1000;

//total run time of light on and light off
var time_in_ms_to_wait_between_recursive_setTimeout = (light_on_for_ms + light_off_for_ms);

//set the count to 1
var count = 1;

var tostopit;

//function to count the number of blinks and stop timmer
function blinks()
{
if (numberofblinks <= count)
{
//stop the recursive setTimeout
clearTimeout(tostopit);

}
else
{
    count++;
}

}

//function to set payload to true
function payload_true()
{
//set payload to true
node.send({payload:true});

//display green dot when light is on
node.status({
                fill: 'green',
                shape: 'dot',
                text: ' '
            });

}

//function to set payload to false
function payload_false()
{
//set payload to false
node.send({payload:false});

//clear status when payload false
node.status({
        });

}

//run the light show!!!!
setTimeout(function run()
{
//turn the light on by setting msg.payload to true
payload_true();

//turn the light off by waiting to set the payload to false by the ammount of time light is on
setTimeout(payload_false, light_on_for_ms);

//total ammount of time light can be on or off before it runs again
tostopit = setTimeout(run, time_in_ms_to_wait_between_recursive_setTimeout);

blinks();

}, time_in_ms_to_wait_before_first_execution);

return msg;

code i am using so far

cflurin · 29 December 2018 12:39

@gbond,

To simplify code copy add a line with ``` at the begin and at the end of your code.

gbond · 29 December 2018 12:48

sorry dont understand

gbond · 29 December 2018 12:49

also the timing seem all over the place now seem to work better with the error

cflurin · 29 December 2018 12:52

see https://discourse.nodered.org/t/how-to-share-code-or-flow-json/506

knolleary · 29 December 2018 12:55

@gbond when you share code or flows in this forum, it helps to format it properly so it displays clearly. The post @cflurin has linked to (and to which I pointed you at much earlier on in this thread) describes how to do it.

gbond · 29 December 2018 12:58

ok read your post but i dont see what has changed am i missing some thing?

the codeing looks exactly the same!

Paul-Reed · 29 December 2018 13:16

That's because you have not edited your post above, and formatted it as per the requests.
If you want us to help you, you have to help us a little and format your code!

gbond · 29 December 2018 13:18

I think i have worked it out! "do you mean its lost it's colouring" sorry for being so slow

gbond · 29 December 2018 13:20

//get the values of msg.* to var's
var numberofblinks = msg.numberofblinks;
var light_on_for_ms = msg.lighton;
var light_off_for_ms = msg.lightoff;
//var run;

//how long to wait before starting the light show
var time_in_ms_to_wait_before_first_execution = 1000;

//total run time of light on and light off
var time_in_ms_to_wait_between_recursive_setTimeout = (light_on_for_ms + light_off_for_ms);

//set the count to 1
var count = 1;

    var tostopit;

//function to count the number of blinks and stop timmer
function blinks()
{
    if (numberofblinks <= count)
    {
        //stop the recursive setTimeout
        clearTimeout(tostopit);
    
    }
    else
    {
        count++;
    }
}



//function to set payload to true
function payload_true()
{
    //set payload to true
    node.send({payload:true});
    
    //display green dot when light is on
    node.status({
                    fill: 'green',
                    shape: 'dot',
                    text: ' '
                });
}

//function to set payload to false
function payload_false()
{
    //set payload to false
    node.send({payload:false});
    
    //clear status when payload false
    node.status({
            });
}


//run the light show!!!!
setTimeout(function run() 
{
    //turn the light on by setting msg.payload to true
    payload_true();
    
    //turn the light off by waiting to set the payload to false by the ammount of time light is on
    setTimeout(payload_false, light_on_for_ms);
    
    //total ammount of time light can be on or off before it runs again
    tostopit = setTimeout(run, time_in_ms_to_wait_between_recursive_setTimeout);
    
    blinks();
    
}, time_in_ms_to_wait_before_first_execution);

return msg;

gbond · 29 December 2018 13:27

I think you code is right I think you have put a delay start that made the timing seem different

cflurin · 29 December 2018 13:43

@gbond

What is time_in_ms_to_wait_before_first_execution for?

I've removed it and changed the "style" a little bit:

//get the values of msg.* to var's
var numberofblinks = msg.numberofblinks;
var light_on_for_ms = msg.lighton;
var light_off_for_ms = msg.lightoff;

//total run time of light on and light off
var time_in_ms_to_wait_between_recursive_setTimeout = (light_on_for_ms + light_off_for_ms);

//set the count to 1
var count = 1;

var tostopit;

//function to count the number of blinks and stop timmer
function blinks() {
    if (numberofblinks <= count) {
        //stop the recursive setTimeout
        clearTimeout(tostopit);
    } else {
        count++;
    }
}

//function to set payload to true
function payload_true() {
    //set payload to true
    msg.payload = true;
    node.send(msg);

    //display green dot when light is on
    node.status({fill: 'green', shape: 'dot', text: ' '});
}

//function to set payload to false
function payload_false() {
    //set payload to false
    msg.payload = false;
    node.send(msg);

    //clear status when payload false
    node.status({});
}

//run the light show!!!!
setTimeout(function run() {
    //turn the light on by setting msg.payload to true
    payload_true();

    //turn the light off by waiting to set the payload to false by the ammount of time light is on
    setTimeout(payload_false, light_on_for_ms);

    //total ammount of time light can be on or off before it runs again
    tostopit = setTimeout(run, time_in_ms_to_wait_between_recursive_setTimeout);

    blinks();

}, 0);

return null;

Topic		Replies	Views
Convert object in array General	6	1344	17 July 2021
Raspberry gpio keep output General	1	571	10 June 2019
Python function and variable General	9	475	7 January 2022
Convert a Buffer into a JavascriptObject General	2	459	14 November 2018
Need help in Nested JSON object General function-node	9	109	11 April 2023

How to convert to a function

Related Topics