# Should the double exclamation mark for imported configuration disapper after deploy?

**URL:** <https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348>\
**Category:** Core Development\
**Created:** [29 May 2024 10:46 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348 "2024-05-29T10:46:16Z")\
**Posts on this page:** 12\
**Page:** 1

<div class="post-metadata">

**Author:** ![AGhorab](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/aghorab/32/87562_2.png) [@AGhorab](https://discourse.nodered.org/u/AGhorab)\
**Post date:** [29 May 2024 10:46 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/1 "2024-05-29T10:46:16Z")

</div>

When I import a flow with a Configuration node that already exists, a new configuration is added to the Configuration Nodes tab. It ends with '!!', which seems to be expected behavior based on my code review.

However, the '!!' suffix remains on the configuration node even after clicking the Deploy button. It's only removed after refreshing the page.

Should the '!!' be automatically removed when the configuration is deployed, or is this the expected behavior? I want to confirm this before creating an issue on GitHub.

This are the images during import and configuration window

![image](https://us1.discourse-cdn.com/flex026/uploads/nodered/original/3X/b/6/b60a2efed2016b109e769351f55c48daab29bdef.png)

![image](https://us1.discourse-cdn.com/flex026/uploads/nodered/original/3X/7/8/78dac3f0e4f3c54af97aa51b3b15ca7a81e46e28.png)

---

<div class="post-metadata">

**Author:** ![Steve-Mcl](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/steve-mcl/32/4826_2.png) [@Steve-Mcl](https://discourse.nodered.org/u/Steve-Mcl)\
**Post date:** [29 May 2024 10:53 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/2 "2024-05-29T10:53:46Z")

</div>

hi, please provide a super simple reproducible demo.

I expect there will be 2 super simple flows (perhaps even just 1 node to which this config points at).

1. flow 1 should be the before state
2. flow 2 should be what you import
3. step by step instructions (i.e. did you click "replace", order of events etc).
4. If your demo includes any non core nodes, include the full name of the contrib node used

* * *

NOTE: I removed the dashboard tag and moved this to #Core Development since it looks like any kind of node might have this "bug".

---

<div class="post-metadata">

**Author:** ![AGhorab](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/aghorab/32/87562_2.png) [@AGhorab](https://discourse.nodered.org/u/AGhorab)\
**Post date:** [29 May 2024 12:24 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/3 "2024-05-29T12:24:07Z")

</div>

Sure, the test is simple i attached a flow that can be used as flow 1 and flow 2 using mqtt in node (since it's one of the out of the box nodes that have configuration section)

1. Import the flow which would add a configuration node and mqtt with a debug node very simple.
2. Deploy and refresh the page
3. Import the Flow one more time
4. Click View nodes
5. check on the configuration node (no check on replace)
6. Click on Import selected
7. Check the configuration nodes tab
8. you should see 2 configurations (1 from first import and 1 from second)
9. the second one would have '!!' in the end (which is expected from my code review)
10. Click Deploy, the '!!' will still be there but will be removed when refresh

Flow:  
[flows.json](https://discourse.nodered.org/uploads/short-url/3tPwQs5Pkzz2yKi2JbcqJdFpOAD.json) (1.6 KB)

---

<div class="post-metadata">

**Author:** ![GogoVega](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/gogovega/32/71313_2.png) [@GogoVega](https://discourse.nodered.org/u/GogoVega)\
**Post date:** [29 May 2024 18:41 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/4 "2024-05-29T18:41:31Z")

</div>

Confirmed, I'm going to push a fix 😉

PS: The `"!!"` means that the config node has changed.

---

<div class="post-metadata">

**Author:** ![knolleary](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/knolleary/32/3_2.png) [@knolleary](https://discourse.nodered.org/u/knolleary)\
**Post date:** [29 May 2024 18:54 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/5 "2024-05-29T18:54:41Z")

</div>

> [@GogoVega](#):
>
> The `"!!"` means that the config node has changed.

I'd forgotten we did that.

I did make a start on adding proper change icons to the config node sidebar, but it opened a can of worms I decided to step away from this close to 4.0....

---

<div class="post-metadata">

**Author:** ![GogoVega](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/gogovega/32/71313_2.png) [@GogoVega](https://discourse.nodered.org/u/GogoVega)\
**Post date:** [29 May 2024 18:57 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/6 "2024-05-29T18:57:02Z")

</div>

Sorry, I did'nt understand everything 🤔 😅

Did you want to add some sort of badge (or other) but forgot that this indication existed?

---

<div class="post-metadata">

**Author:** ![GogoVega](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/gogovega/32/71313_2.png) [@GogoVega](https://discourse.nodered.org/u/GogoVega)\
**Post date:** [29 May 2024 19:05 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/7 "2024-05-29T19:05:00Z")

</div>

> [@GogoVega](#):
>
> Confirmed, I'm going to push a fix 😉

> <https://github.com/node-red/node-red/pull/4734>
>
> \- \[x\] Bugfix (non-breaking change which fixes an issue)
> \- \[\] New feature (non-…breaking change which adds functionality)
> 
> \## Proposed changes
> 
> Fix the Sidebar Config is not refreshed after a deploy.
> 
> Issue described in the \[Forum\](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348).
> 
> \## Checklist
> 
> \- \[x\] I have read the \[contribution guidelines\](https://github.com/node-red/node-red/blob/master/CONTRIBUTING.md)
> \- \[\] For non-bugfix PRs, I have discussed this change on the forum/slack team.
> \- \[x\] I have run \`npm run test\` to verify the unit tests pass
> \- \[\] I have added suitable unit tests to cover the new/changed functionality

---

<div class="post-metadata">

**Author:** ![knolleary](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/knolleary/32/3_2.png) [@knolleary](https://discourse.nodered.org/u/knolleary)\
**Post date:** [29 May 2024 19:54 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/8 "2024-05-29T19:54:43Z")

</div>

> [@GogoVega](#):
>
> Did you want to add some sort of badge (or other) but forgot that this indication existed?

Ultimately, the nodes should have the same blue dot as we use in the workspace. The `!!` change was a quick hack to do _something_ - but there is no hint to the user what it means and is entirely inconsistent.

Your fix for the immediate issue is welcome for 4.0. After 4.0 we can look at adding a proper change indicator to the nodes.

---

<div class="post-metadata">

**Author:** ![GogoVega](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/gogovega/32/71313_2.png) [@GogoVega](https://discourse.nodered.org/u/GogoVega)\
**Post date:** [29 May 2024 20:01 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/9 "2024-05-29T20:01:05Z")

</div>

This makes me think that there is also the error badge for the config node.

The badge exists but node.valid is not updated.

---

<div class="post-metadata">

**Author:** ![knolleary](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/knolleary/32/3_2.png) [@knolleary](https://discourse.nodered.org/u/knolleary)\
**Post date:** [29 May 2024 21:41 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/10 "2024-05-29T21:41:44Z")

</div>

@GogoVega yes. I mentioned in my post about the can of worms I opened. I don't know if that translates - but basically, yes, there's a bunch of internal state in the editor that we track for flow nodes that we don't track for config nodes which is needed to properly manage the change/error icons for the config nodes. I started working through it, but put it on pause as it needed more than I was expecting and that I had time for.

---

<div class="post-metadata">

**Author:** ![AGhorab](https://sea2.discourse-cdn.com/flex026/user_avatar/discourse.nodered.org/aghorab/32/87562_2.png) [@AGhorab](https://discourse.nodered.org/u/AGhorab)\
**Post date:** [4 June 2024 12:09 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/11 "2024-06-04T12:09:18Z")

</div>

Thanks for the fix everyone.

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex026/uploads/nodered/original/1X/d073cd938eafa2e558d7c2cd59003b3ef4963033.png) [@system](https://discourse.nodered.org/u/system)\
**Post date:** [2 September 2024 12:09 UTC](https://discourse.nodered.org/t/should-the-double-exclamation-mark-for-imported-configuration-disapper-after-deploy/88348/12 "2024-09-02T12:09:57Z")

</div>

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.