Updating, nodejs, and other things

General
41

Yes, looks like a bug. Should be 16 as the else defaults to 18

e.g...

            if [[ "$NODE_VERSION" == "12" ]]; then
                tgtl=$tgtl12
                tgta=$tgta12
            elif [[ "$NODE_VERSION" == "14" ]]; then
                tgtl=$tgtl14
                tgta=$tgta14
            elif [[ "$NODE_VERSION" == "18" ]]; then
                tgtl=$tgtl18
                tgta=$tgta18
            elif [[ "$NODE_VERSION" == "20" ]]; then
                tgtl="None"
                tgta=$tgta20
            else
                tgtl=$tgtl18
                tgta=$tgta18
                NODE_VERSION="18"
            fi

Should be

            if [[ "$NODE_VERSION" == "12" ]]; then
                tgtl=$tgtl12
                tgta=$tgta12
            elif [[ "$NODE_VERSION" == "14" ]]; then
                tgtl=$tgtl14
                tgta=$tgta14
            elif [[ "$NODE_VERSION" == "16" ]]; then
                tgtl=$tgtl16
                tgta=$tgta16
            elif [[ "$NODE_VERSION" == "20" ]]; then
                tgtl="None"
                tgta=$tgta20
            else
                tgtl=$tgtl18
                tgta=$tgta18
                NODE_VERSION="18"
            fi
42

I suspected that, but am not so .... arrogant to think I was right.

It just didn't look right and as it went: 12, 14, 18, 20.... It was kinda obvious that - somehow - 16 got left out.

But the lines after were also 16 18 - which I can understand. (edited from 16 to 18)

I just wanted to check.

If it - the script - gets updated, I may try to install 16 on one of the older machines just to see if it does work.

43

Will you get it sorted Steve, or should I submit a bug (against what?)?

44

will need an issue raised Colin.

feel free to PR too :wink: :crossed_fingers:

45

Already fixed...

2 Likes
46

Excellent, thanks.

47

Just for keeping you (all) in the loop.

Updated the two machines to node v16. Working.

2 Likes
48

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.