Credentials for "function" node

Core Development Feature Requests
1

Hello,

I've implemented a new functionality for "function" node for configuring a single pair of credentials and make them available for use in function's code. It's based on already available credentials framework for node development, really a simple patch.
What's your opinion, will this be a valuable addition and should I open a PR for it?

2

Hi,
What do you mean by that ?
Password type credentials are not readable by the editor. If you bypass this, you leave the editor vulnerable.

3

@dpslavov a screenshot might help demonstrate what you are proposing.

In general, we have various other ways to make credentials available to a node. For example, you can add an env var at the Group, Subflow or Flow level that is stored as a credential:

image
image1064×474 17.9 KB

The node can then just use env.get('my secret') to retrieve the value.

4

Hi,

You are confusing code with editor. What I mean is that node object has new property credentials which you can use in your code like this:

const username = node.credentials.username;
const password = node.credentials.password;

In this way you don't have to have plaintext passwords in your flow.

5

@knolleary Here are some screenshots:

image
image

To be honest I didn't knew that environment variables can be stored as secrets, if I knew that probably I wouldn't implement this patch...

6

Although I don't think this is a bad idea, what if you need more than 1 credential ?
Note that there is a dedicated node available for influx.

7

Node's credentials implementation isn't well suited for multiple records. Of course it isn't impossible to to implement such thing but I preferred clean implementation and easy of use over functionality.
Yes, I'm aware that several InfluxDB contrib nodes do exists.