Looking at javascript examples and source code for node red palette packages, the use of "var" to declare variables is rampant. I can only see a few reasons for this: People who write this code doesn't know any better. Muscle memory, old/bad habits. Ancient code not updated. Bad code being so wid…

[image] ThingsTinkerer: Ancient code not updated. [image] ThingsTinkerer: This would easily be solved Maybe easy, but also time consuming. It requires someone to put the time in when there are other priorities.

Admittedly those configs are a hassle, and time is long overdue for an industry standard to copy-paste from. Chatgpt or similar should also be able to make something fairly decent instantly. Best case it's a matter of spending 10 min setting up a project before writing code. A one-time job. If you h…

Haha don't touch it yeah, related to "ancient code not updated". You would have some extremely specific cases where changing "var" to "const"/"let" breaks something. Average node-red level is far below that level.

[image] ThingsTinkerer: Best case it's a matter of spending 10 min setting up a project before writing code Plus all the re-testing, release notes, pushing to github releasing to npm, etc. And for what purpose?

For what purpose? You mean having a linter and formatter for your project? If you spent 10 min beforehand, you wouldn't need to do additional re-testing, release notes, push to github and npm release. If you do it afterwards, then yeah. Tests can be automated, so ideally that'll be no issue. Pushing…

I have many older function nodes using var and many newer function nodes using let and const. As far as I know they all work fine. If there was a tool to rewrite these old functions, what would I gain by using it?

That'll be " Ancient code not updated." :grinning: Cleaner code? Best-practice? You can write entire code on single line too if you want, still works fine. Yet using a formatter would be much better (with negligible cost in setup).

Well I'm sure that since you think this should be done, you could start making changes and submit PR to have the code changed.

You don't agree that var shouldn't be used? Instead of fixing it, it would be far more practical to set up a CI/CD pipeline to prevent it ever happening in the first place.

Node-RED

Node-RED Forum

JS, people still use var?

General

hotNipi 9 October 2024 09:21 2

Missing point 4. "If it's working, don't touch it."

5 Likes

Topic		Replies	Views
Function nodes and `let` for variables General	31	846	2 April 2023
Where to use let and where to use var in a function node? General	10	3898	21 November 2020
Nodered 3.02 functions General function-node	14	424	29 October 2022
Some thoughts for people who like `function` nodes and coding General	36	485	9 January 2026
Function node & var definition General function-node	47	1123	17 December 2022

Copyright OpenJS Foundation and Node-RED contributors. All rights reserved. The OpenJS Foundation has registered trademarks and uses trademarks. For a list of trademarks of the OpenJS Foundation, please see our Trademark Policy and Trademark List. Trademarks and logos not indicated on the list of OpenJS Foundation trademarks are trademarks™ or registered® trademarks of their respective holders. Use of them does not imply any affiliation with or endorsement by them.

JS, people still use var?

Related topics