Node Red emailer and 0auth2- "ReferenceError: msg is not defined" function check

marcus-j-davies · 6 March 2024 17:08

I think this is a bug with the node - or at least its assumptions are incorrect.

The node initializer is expecting an msg property - but during init, it will not exist?

C'tor

node-red/node-red-nodes/blob/fd027aa95a5c0847596a96705c3a05c969ae39a9/social/email/61-email.js#L30


      
          var nodemailer = require("nodemailer");
          var simpleParser = require("mailparser").simpleParser;
          var SMTPServer = require("smtp-server").SMTPServer;
          //var microMTA = require("micromta").microMTA;
          var fs = require('fs');
          
          if (parseInt(process.version.split("v")[1].split(".")[0]) < 8) {
              throw "Error : Requires nodejs version >= 8.";
          }
          
          function EmailNode(n) {
              RED.nodes.createNode(this,n);
              this.topic = n.topic;
              this.name = n.name;
              this.outserver = n.server;
              this.outport = n.port;
              this.secure = n.secure;
              this.tls = true;
              this.authtype = n.authtype || "BASIC";
              if (this.authtype !== "BASIC") {
                  this.inputs = 1;

Trying to use msg in there

github.com

node-red/node-red-nodes/blob/fd027aa95a5c0847596a96705c3a05c969ae39a9/social/email/61-email.js#L82


      
              tls: {rejectUnauthorized: node.tls}
          }
          
          if (node.authtype === "BASIC" ) {
              smtpOptions.auth = {
                  user: node.userid,
                  pass: node.password
              };
          }
          else if (node.authtype === "XOAUTH2") {
              var value = RED.util.getMessageProperty(msg,node.token);
              if (value !== undefined) {
                  if (node.saslformat) {
                      //Make base64 string for access - compatible with outlook365 and gmail
                      saslxoauth2 = Buffer.from("user="+node.userid+"\x01auth=Bearer "+value+"\x01\x01").toString('base64');
                  } else {
                      saslxoauth2 = value;
                  }
              }
              smtpOptions.auth = {
                  type: "OAuth2",

This would explain the error occurring during deploy?

IMO adjusting SMTP auth methods should be occurring on input ?
certainly if auth values are to be taken from msg

I might be a little rusty - so forgive me, if i'm just talking rubbish

Topic		Replies	Views
Can send e-mail but the message is undefined General	9	1148	1 November 2021
Waiting for missing types to be registered - node-red-node-email General	9	443	24 December 2022
Email Node and OAuth with M365 General	1	487	25 April 2023
Email node shows "invalid properties: token", but works General possible-bug	1	195	9 January 2024
NodeRed and OAuth2 General	9	1017	9 February 2023

Node Red emailer and 0auth2- "ReferenceError: msg is not defined" function check

Related topics