You would still be able to have your mouse where it needs to be next. You dont need to click on the buttons, just use the built in keyboard shortcut to save or cancel form changes.
I think that's where my suggestion is at its most crucial....
It doesn't require a sudden change to the way I use Node RED
example - I don't use keyboard shortcuts (like at all), I'm sure there are others.
Having a user option, to control this behaviour, I think will address this change well, but also, not screwing around with the muscle memory we tend to develop around the workspace.
It allows both parties to benefit
Not sure how this will play out of course, but my opinion, is to allow the user to have control of this behaviour, via Settings In the UI.
1 Like
I think if it was changed, a lot of people would realise they do that right now.
+1 for it to be an option, I think its only fair 
1 Like
WRT the esc button closing the editor, my 2 cents would be ...
This would be Ok if the user knows (remembers?) what happens when they they hit the esc key, accidentally or not. New(er) users will not, in fact I'd not know unless I participated in this msg thread.
Even if you describe the behavior in on-line tutorials, it is unlikely a user would read it before having the experience. So I'd vote against changes that could possibly leave a user in a position of "Oh, Oh, did I just lose all my changes, or not?". Often one cannot remember exactly all the edits they just made.
This reminds me of using (too touchy) cell phone or tablet apps these days when you accidentally touch the screen and everything changes, leaving you to wonder where you are and how you got there.
Prefer the certainty of having to click either Cancel or Done.
1 Like
To satisfy everyone, a compromise would be:
ctrl-enter: saves changes and closes the edit box.
ctrl-escape: discards changes and closes the edit box.
(actual default keys)
A new selection parameter in the editor settings:
nothing: (default for new users) assumes that clicking outside the edit box does nothing.save and exit: (default for current users) keeps the current behavior (saves changes and closes the edit box).discard and exit: discards changes and closes the edit box. (my preference)
This way, everyone is happy and it provides more choices.
3 Likes
I prefer the current state. Sometimes I need to check a few nodes to see their current settings, and clicking outside the window to close it a great option for me.
If things are changed to no longer do that, I would like a user setting to return that please.
1 Like
I went with Something Else and then saw the comments regarding prompting for the action and the nature of the edit dialog. My thought was prompt to Save/Discard if an edit was made. I do see the comment that the nature of the editor means that it is not known if there has been a change so therefore the prompt would always occur, even when no edits are made. IF the action is to save changes, does this also mean that the node is marked as modified even if no change were made? It currently does not so therefore at some point it is known that no changes were actually made. I do not know how difficult it would be to implement, but if possible, I believe this is what I would have expected.
Note that until reading this, I did not realize clicking outside closed and saved the changes.
Then question is that is that is it better to fix that edit form than try fix symptom? Naturally it is much much bigger work to modify it to know states but I assume that is not impossible neither. After all there is 2 versions of data because cancel is possible. So probably some kind way to compare those will resolve problem?
