Simple function help

[leftymuller]

Hey Gents,

I wrote a function that spins messages around, doesnt seem to work

function setrainfall() {
msg.payload = global.get('rainfall');
global.set('rotation')==2;
}

function sethumidity() {
msg.payload = global.get('humidity');
global.set('rotation')==3;
}

function setwindspeed() {
msg.payload = global.get('windspeed');
global.set('rotation')==1;
}

if (global.get('rotation') ==1) { setrainfall() }
if (global.get('rotation') ==2) { sethumidity() }
if (global.get('rotation') ==3) { setwindspeed() }
return msg;

any javascript help apprecciated

[dceejay]

Maybe you need some else calls to go with your ifs

[Colin]

@leftymuller

global.set('rotation')==1

Those should all be like global.set('rotation', 1)

[leftymuller]

global.set('rotation', 1);
function setrainfall() {
msg.payload = global.get('rainfall');
global.set('rotation', 2);
}

function sethumidity() {
msg.payload = global.get('humidity');
global.set('rotation', 3);
}

function setwindspeed() {
msg.payload = global.get('windspeed');
global.set('rotation', 1);
}

if (global.get('rotation'), 1) { setrainfall() }
if (global.get('rotation'), 2) { sethumidity() }
if (global.get('rotation'), 3) { setwindspeed() }
return msg;

still get undefined payload?

[Colin]

Are you setting globals rainfall etc?

Also I don't see that function is performing any useful function. You set rotation to 1 at the start which will cause setrainfall to be cause, which sets it to 2 so then sethumidity will be called which sets it 3 so then setwindspeed will be called which sets it back to 1 again. msg.payload will always be the windspeed value.

[E1cid]

@leftymuller

if (global.get('rotation'), 1) { setrainfall() }
if (global.get('rotation'), 2) { sethumidity() }
if (global.get('rotation'), 3) { setwindspeed() }

you seem to have edited your if statements.
Now there are no comparisons

[Colin]

I had missed that, @leftymuller you should not have edited the global.get statements, just the global.set. Go and look at the docs for using context again.

[leftymuller]

global.set('rotation', 1);
function setrainfall() {
msg.payload = global.get('rainfall');
global.set('rotation', 2);
}

function sethumidity() {
msg.payload = global.get('humidity');
global.set('rotation', 3);
}

function setwindspeed() {
msg.payload = global.get('windspeed');
global.set('rotation', 1);
}

if (global.get('rotation') == 1) { setrainfall() }
if (global.get('rotation') == 2) { sethumidity() }
if (global.get('rotation') == 3) { setwindspeed() }
return msg;

still gives payload undefined

@colin the global.set for humidity, windspeed and rainfall are set and working.. currently im using timed injects to achieve the changing of the weather but its clunky and gets out of time.. thats why i thought a function was a more elegant way of doing it

[{"id":"eb3d7fa.90ab38","type":"tab","label":"test page","disabled":false,"info":""},{"id":"fe1746ff.1fbec8","type":"function","z":"eb3d7fa.90ab38","name":"","func":"global.set('rotation', 1);\nfunction setrainfall() {\n                         msg.payload = global.get('rainfall');\n                         global.set('rotation', 2);\n                        }\n\nfunction sethumidity() {\n                         msg.payload = global.get('humidity');\n                         global.set('rotation', 3);\n                        }\n                        \nfunction setwindspeed() {\n                         msg.payload = global.get('windspeed');\n                         global.set('rotation', 1);\n                        }     \n                        \nif (global.get('rotation') == 1) { setrainfall() }\nif (global.get('rotation') == 2) { sethumidity() }\nif (global.get('rotation') == 3) { setwindspeed() }\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","x":400,"y":220,"wires":[["1b6d5bac.08e2a4"]]},{"id":"30e85221.555c3e","type":"inject","z":"eb3d7fa.90ab38","name":"","props":[{"p":"trigger1","v":"ok","vt":"str"}],"repeat":"20","crontab":"","once":true,"onceDelay":0.1,"topic":"","x":220,"y":220,"wires":[["fe1746ff.1fbec8"]]},{"id":"1b6d5bac.08e2a4","type":"debug","z":"eb3d7fa.90ab38","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":560,"y":220,"wires":[]}]

[E1cid]

try

if (global.get('rotation') == 1) { setrainfall() }
else if (global.get('rotation') == 2) { sethumidity() }
else if (global.get('rotation') == 3) { setwindspeed() }
else {setrainfall()}
return msg;

as maybe global rotation is not set

[Colin]

Add node.warn() statements at relevant places to work out what is happening. If you don't know how to do that I think it is referenced in the Writing Functions doc.

[leftymuller]

@E1cid

if (global.get('rotation') == 1) { setrainfall() }
else if (global.get('rotation') == 2) { sethumidity() }
else if (global.get('rotation') == 3) { setwindspeed() }
else {setrainfall()}
return msg;

outputs that everytime

[E1cid]

Looks like global rotation is not set. Can you show the value of it in the context panel.

[leftymuller]

set to 2 ready for next line of text

[E1cid]

Why limit the info we see?

is that node, flow or global?

if that is global , then there is more happening in your flow and you will have to post it.

[leftymuller]

thanks e1cid.. i posted the flow.. here is all the context data

[E1cid]

The issue is you set rotation to 1 at beginning of function node, delete line 1

[leftymuller]

thats it! working now

Thanks !

One thing I love about node red is the community and the willingness to help.. thanks again