'widget-action' messages set msg.topic to 'undefined' (updated)

Developing Nodes
,
1

I have upgraded my dashboard-2 to v1.23.0.

In my custom UI node, when I send messages as 'widget-action' (this.$socket.emit('widget-action', this.id, msg) ), their topic property is getting overrun and becomes undefined.

This happens also in the generic ui-template node. Using this.send(msg) works OK, but using emit to 'widget-action' overwrites the topic property.
For example, I inject a msg with msg.topic='myTopic'to the template:

mounted() {
	const $scope = this;

	// Socket listener
	this.$socket.on('msg-input:' + this.id, function(msg) {

		msg.payload = "Using 'emit'";
		$scope.$socket.emit('widget-action', $scope.id, msg);

		msg.payload = "Using 'send'";
		$scope.send(msg)
	});
}

and get the following result:

image
image228×333 6.11 KB

@joepavitt - any ideas? this was not happening in earlier dashboard versions.

2

Can you open an issue on the GH repo if you haven't already please @omrid, I know that @Steve-Mcl recently modified some topic-based code for the UI Form, but not sure if that's related.

3

Thanks, I have opened an issue (#1683).

4

Thanks @omrid - just linking to it so that it's easier for future navigation: ‘widget-action’ messages set msg.topic to ‘undefined’ · Issue #1683 · FlowFuse/node-red-dashboard · GitHub

5

Hi @joepavitt, @Steve-Mcl,
I see that dashboard v1.24.0 has been released, with issue 1683 not resolved yet.

Is there any projected date for the fix? (It's OK if not in priority, I just need to know, as I will have to modify my custom UI node to stop using the topic property)

6

That release was for an immediate need we had - sorry it did not include a fix for this one. It will be picked up in due course :crossed_fingers: