The lgtv-ip-control project on github apparently has been abandoned which is unfortunate, because there are several other projects that leverage this one. BitFocus Companion for example.
I have figured out the bug, which came about because the LG WebOS changed a specific response string, so I know the actual code change (in JavaScript) that needs to be done. However, I have no experience or deep understanding of github. Not even sure what the process is to get this bug patched in the current project since it appears to be abandoned.
I guess the project will have to be... cloned? Pulled? into a new project that other maintainers can support?
I edited the LGTV.js file and ran a small test script via 'node' and the fix works... but when I load the modified module into NR, via the settings.js file and then in a flow via global.get() the fix does not appear to be honored... not sure why.
So I was thinking if someone could help by cloning the old project and adding the fix, then NR would load the updated module/library as expected?
Have you tried contacting the author directly, they seem to be on linkedin and their website seems to be up and running since the 90s.
Initially I thought this was a NodeRED package but it's a NPM package that needs to be loaded into NR. That's a non-trivial* workflow - update package, update package.json for NR (or use the function node to load package), update, test, rinse & repeat.
NR manages packages in a different location than one expects, that's because NR does its own NPM package management outside of the normal npm install stuff. I never really got my head around nor do I want to
[*]= Non-trivial for those that don't do it everyday!
This is not really true. It uses the userDir folder (normally ~./node-red/) as its package root. Any node.js app will have a package root somewhere.
If you use UIBUILDER, there is a 2nd package root in the uibuilder root folder (normally ~/.node-red/uibuilder) for packages that you want automatically served to your front-end.
This is certainly the first step. If that fails, and the license allows, you can clone the repo to your own. Then you can work on your own version and publish to npmjs.org.
Wow! What timing... No I did not contact the author as yet. Wes the author of the lgtv-ip-control module has been out of pocket for a while but just today he updated the module... @Jibun-no-Kage, thanks for documenting the error(s) since LGWebOS changed. The update addresses the issues Jibun documented.
