Closing a JSONata editor leaves out a IDLE thread

Core Development
1

@dceejay @knolleary

Dear Sir,
As title said, a thread is left after closing a JSONata editor.

Reproduce Steps:

  1. Open JSONata editor from debug node, we can found there are 3 threads and this is OK.
    image
    image754Ă—628 77.2 KB

2.Click Cancel button, the editor is closed successfully but there left a thread isn't deleted.

image
image780Ă—598 64.2 KB

Reason:
By checking @node-red/editor-client/src/js/ui/edtiors/expression.js,
line 340~line 345, testResultEditor.destroy() is missed.

image

2 Likes
2

Thanks for reporting. Feel free to raise a PR with a fix if you'd like.

3

For awareness, this is already fixed in dev when monaco commit missing editor destroy() calls #251dda3 was merged.

4

Hi Nick, many thanks for your reply. As Steve said, since this PR is already raised, I will skip it.

5

Hi Steve, I see. Many thanks for your reply.

1 Like
6

We should still fix it in the master branch for any future 1.x release

The Dev branch is for the 2.x release.

7

I see. I will raise a PR for it. many thanks.

8

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.