Missing semicolon in style section of ui_base.html

Dashboard
1

Hello,

I don't know if it is the right place to say. Maybe it is better to directly submit an issue or raise a PR but as it is not yet released I prefer to do so.
On the latest master of dashboard on github, a semicolon is missing on line 4 :

 :root {
     --nr-db-dark-text: #444;
     --nr-db-light-text: #eee
     --nr-db-disabled-text: #999;
 }

hence --nr-db-light-text and --nr-db-disabled-text are not defined.
Let me know if you want me to raise a PR or submit an issue.

2

thanks for spotting it - no need - will edit right now - but hmm yeah... they ought to be removed from there at some point so new themeing can work here also.

3

You're welcome.
Just realize that during the test of my custom node (I am using --nr-db-light-text in it ) with latest master from dashboard. I understand I will have to update to fit with new themeing.

4

Is there something to peek into already?

5

As per the 1.0 beta post - 🎉 Node-RED 1.0.0-beta.2 released

6

Ahh ok in this area :slight_smile: