Why does the AND not work

AndyWB · 18 October 2021 18:16

Good evening,
I have two Boolean values. Both of these are true. The AND element always shows unknown and gives nothing out. Where is my mistake?

[
    {
        "id": "3d846a3cec7a7d97",
        "type": "change",
        "z": "da4995d901bb5abd",
        "name": "",
        "rules": [
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "CLOSED",
                "fromt": "str",
                "to": "true",
                "tot": "bool"
            },
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "OPEN",
                "fromt": "str",
                "to": "false",
                "tot": "bool"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 580,
        "y": 180,
        "wires": [
            [
                "418f6185c0335945"
            ]
        ]
    }
]

edje11 · 18 October 2021 18:25

Hi Andy,

Can't import your posted code, it will import only a change node, the other nodes are missing.

jbudd · 18 October 2021 18:26

You have only posted one Change node so it's difficult to advise. But in that node you change OPEN to true and CLOSED to true.

So I suggest you check for similar typos elsewhere.

Edit: I can see the word "false" up there in your post but it doesn't show false when I import it.

AndyWB · 18 October 2021 18:31

[
    {
        "id": "da4995d901bb5abd",
        "type": "tab",
        "label": "Flow 11",
        "disabled": false,
        "info": ""
    },
    {
        "id": "cd2329869f578bf5",
        "type": "openhab2-in",
        "z": "da4995d901bb5abd",
        "name": "",
        "controller": "2341e6d1c1f117f5",
        "itemname": "FensterDurchgangszimmerlinks_OpenClose",
        "x": 290,
        "y": 120,
        "wires": [
            [
                "d1e942d83e070aef"
            ],
            []
        ]
    },
    {
        "id": "d1e942d83e070aef",
        "type": "change",
        "z": "da4995d901bb5abd",
        "name": "",
        "rules": [
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "CLOSED",
                "fromt": "str",
                "to": "true",
                "tot": "bool"
            },
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "OPEN",
                "fromt": "str",
                "to": "false",
                "tot": "bool"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 620,
        "y": 120,
        "wires": [
            [
                "418f6185c0335945"
            ]
        ]
    },
    {
        "id": "35d8f708c4eab8a5",
        "type": "openhab2-in",
        "z": "da4995d901bb5abd",
        "name": "",
        "controller": "2341e6d1c1f117f5",
        "itemname": "FensterDurchgangszimmerrechts_OpenClose",
        "x": 270,
        "y": 200,
        "wires": [
            [
                "3d846a3cec7a7d97"
            ],
            []
        ]
    },
    {
        "id": "3d846a3cec7a7d97",
        "type": "change",
        "z": "da4995d901bb5abd",
        "name": "",
        "rules": [
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "CLOSED",
                "fromt": "str",
                "to": "true",
                "tot": "bool"
            },
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "OPEN",
                "fromt": "str",
                "to": "false",
                "tot": "bool"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 580,
        "y": 180,
        "wires": [
            [
                "418f6185c0335945"
            ]
        ]
    },
    {
        "id": "418f6185c0335945",
        "type": "BooleanLogic",
        "z": "da4995d901bb5abd",
        "name": "",
        "operation": "AND",
        "inputCount": "2",
        "topic": "result",
        "x": 860,
        "y": 160,
        "wires": [
            [
                "01f457d68cf6d103"
            ]
        ]
    },
    {
        "id": "01f457d68cf6d103",
        "type": "debug",
        "z": "da4995d901bb5abd",
        "name": "",
        "active": false,
        "tosidebar": true,
        "console": true,
        "tostatus": true,
        "complete": "payload",
        "targetType": "msg",
        "statusVal": "payload",
        "statusType": "auto",
        "x": 1070,
        "y": 200,
        "wires": []
    },
    {
        "id": "2341e6d1c1f117f5",
        "type": "openhab2-controller",
        "name": "Ziegler",
        "protocol": "http",
        "host": "192.168.178.YYY",
        "port": "8080",
        "path": "",
        "username": "oh.NODERED.xyzz",
        "password": ""
    }
]

AndyWB · 18 October 2021 18:32

[
    {
        "id": "da4995d901bb5abd",
        "type": "tab",
        "label": "Flow 11",
        "disabled": false,
        "info": ""
    },
    {
        "id": "cd2329869f578bf5",
        "type": "openhab2-in",
        "z": "da4995d901bb5abd",
        "name": "",
        "controller": "2341e6d1c1f117f5",
        "itemname": "FensterDurchgangszimmerlinks_OpenClose",
        "x": 290,
        "y": 120,
        "wires": [
            [
                "d1e942d83e070aef"
            ],
            []
        ]
    },
    {
        "id": "d1e942d83e070aef",
        "type": "change",
        "z": "da4995d901bb5abd",
        "name": "",
        "rules": [
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "CLOSED",
                "fromt": "str",
                "to": "true",
                "tot": "bool"
            },
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "OPEN",
                "fromt": "str",
                "to": "false",
                "tot": "bool"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 620,
        "y": 120,
        "wires": [
            [
                "418f6185c0335945"
            ]
        ]
    },
    {
        "id": "35d8f708c4eab8a5",
        "type": "openhab2-in",
        "z": "da4995d901bb5abd",
        "name": "",
        "controller": "2341e6d1c1f117f5",
        "itemname": "FensterDurchgangszimmerrechts_OpenClose",
        "x": 270,
        "y": 200,
        "wires": [
            [
                "3d846a3cec7a7d97"
            ],
            []
        ]
    },
    {
        "id": "3d846a3cec7a7d97",
        "type": "change",
        "z": "da4995d901bb5abd",
        "name": "",
        "rules": [
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "CLOSED",
                "fromt": "str",
                "to": "true",
                "tot": "bool"
            },
            {
                "t": "change",
                "p": "payload",
                "pt": "msg",
                "from": "OPEN",
                "fromt": "str",
                "to": "false",
                "tot": "bool"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 580,
        "y": 180,
        "wires": [
            [
                "418f6185c0335945"
            ]
        ]
    },
    {
        "id": "418f6185c0335945",
        "type": "BooleanLogic",
        "z": "da4995d901bb5abd",
        "name": "",
        "operation": "AND",
        "inputCount": "2",
        "topic": "result",
        "x": 860,
        "y": 160,
        "wires": [
            [
                "01f457d68cf6d103"
            ]
        ]
    },
    {
        "id": "01f457d68cf6d103",
        "type": "debug",
        "z": "da4995d901bb5abd",
        "name": "",
        "active": false,
        "tosidebar": true,
        "console": true,
        "tostatus": true,
        "complete": "payload",
        "targetType": "msg",
        "statusVal": "payload",
        "statusType": "auto",
        "x": 1070,
        "y": 200,
        "wires": []
    },
    {
        "id": "2341e6d1c1f117f5",
        "type": "openhab2-controller",
        "name": "Ziegler",
        "protocol": "http",
        "host": "192.168.178.XX",
        "port": "8080",
        "path": "",
        "username": "xxxxxxx",
        "password": ""
    }
]

jbudd · 18 October 2021 18:33

Sorry, that won't import either, click the "Preformatted text" button then paste over the highlighted line.
Done...

zenofmud · 18 October 2021 18:34

Hi, in order to make code more readable and importable it is important to surround your code with three backticks
```
like this
```

You can edit and correct your post by clicking the pencil icon.

See this post for more details - How to share code or flow json

jbudd · 18 October 2021 18:42

Do your inputs have msg.topic set?
Try setting two different topics in the change nodes.

The importing false as true is a problem at my end, it imports OK on another computer.

zenofmud · 18 October 2021 18:45

Andy

You have a couple issues in your change nodes. You have:
Screen Shot 2021-10-18 at 2.40.25 PM
and you are replacing the values you search for. That means that if you sent in the string "CLOSED and OPEN" you would end up with "true and true" so unless both inputs were exactly same thing, the result will always be FALSE. If you sent "valve 2 is open" and "valve 4 is open" you would still get a FALSE becasue the replace would return the messages "valve 2 is true" and "xvalve 4 is true" and they don't match.

Put a debug node on the output of every node (and name them) and run your test so you can see what data is coming thru and how it will react.

jbudd · 18 October 2021 18:48

@zenofmud, could there be a problem in Node-Red's import function?
If you look at the code @AndyWB first posted in this thread, it clearly shows Change string OPEN to boolean false.

AndyWB · 18 October 2021 18:50

zenofmud · 18 October 2021 18:56

What does the data coming into the two change nodes look like?

@jbudd Nope, the import imports it correctly but the search replaces only the value searched for not the entire msg.payload and the end result is a string containing the words 'true' or 'false' with what ever text was originally in the incoming msg.payload. This is why it is important to look at the data going into and out of a node when you don't get the results you expect.

AndyWB · 18 October 2021 19:02

That is the content of the object. I have no idea what I have to do so that I actually only get true or false.
grafik

{"_msgid":"d128fce2e164cd82","payload":true,"item":"FensterDurchgangszimmerlinks_OpenClose","event":"StateEvent"}

zenofmud · 18 October 2021 19:19

What node is that coming from?
Is that the incoming data?
What comes from the other node?
What is in msg.topic?What comes out of the two change nodes?

jbudd · 18 October 2021 19:20

I don't think it does. I've posted about it on the 2.1.0beta.2 thread

zenofmud · 18 October 2021 19:29

Well then wwe need to know what version of Node-RED @AndyWB is running.
(@jbudd good spot!)

jbudd · 18 October 2021 19:31

@AndyWB did you try setting msg.topic in your change nodes?

zenofmud · 18 October 2021 20:15

@jbudd I just checked and it imports fine in v2.0.6 so that is another 2.1.0 beta bug. Like I said good spot!

Paul-Reed · 18 October 2021 20:21

For info;

AndyWB · 19 October 2021 17:08

I work with 2.0.6: Maintenance Release
I hope this will help you, to help me

Topic		Replies	Views
A bug, or a misunderstanding on my end? General	17	861	18 March 2022
Is there an AND node? General	8	517	2 April 2021
Struggle with boolean General	21	1432	26 April 2021
Change node problem General	16	3350	22 October 2019
Change Node not working General	4	287	8 April 2022

Why does the AND not work

Related topics