With a core Dark Theme, node authors can ship their nodes with at least 2 colors and icons variants. When the theme is changed, the editor redraws the node selecting the right variant based on the current theme. Nodes that don't support the core Light/Dark themes will lose points in that site where people can find nodes. To reach max score in that site, devs must define Light/Dark themes for their nodes.
A core Dark Theme is a must nowadays. It is good for our eyes, reduce blue light, a ton of young developers like it, it is trend, it saves energy in devices that use AMOLED/OLED (Node-RED can then be promoted as ENVIRONMENT FRIENDLY hahahahaha -> joke)
However, if you've look at the core code, some of it has "evolved" over the years and there is a mix of classes and manual styling. Also, there is a lot of px based styling rather than % or em units. Not really a criticism, the world of HTML and CSS has changed dramatically over the 10+ years of Node-RED.
Even with clean, structured styling, getting a workable light/dark style can be a challenge.
However, yes, I agree that this would be good. As always though, the question is, who is available to do the work, and would efforts be better spent elsewhere?
Perhaps it would be good to get a custom dark theme together as a foundation and then get a community effort to test and improve if needed? Then, if we can get community consensus, we could request that it be adopted into core.