BUG: Email node doesn't use node name for debug message

daxliniere · 28 January 2022 23:59

I just spotted that the node name in the debug messages for the send email node displays the To field instead of the Name field.

knolleary · 29 January 2022 00:18

The Debug displays the label of the node - what it shows in the workspace - which may not be the name.

In this instance, it looks like the email node displays the to field, if set, in preference to the name.

github.com

node-red/node-red-nodes/blob/5c333db0ddb445442a998452e7c55e89b81e08da/social/email/61-email.html#L89

      
        
                global: { type:"boolean"}
            },
            inputs:1,
            outputs:0,
            icon: "envelope.png",
            align: "right",
            paletteLabel: function() {
                return this._("email.email");
            },
            label: function() {
                return this.dname||this.name||this._("email.email");
            },
            labelStyle: function() {
                return (this.dname)?"node_label_italic":"";
            },
            oneditprepare: function() {
                if (this.credentials.global) {
                    $('#node-tip').show();
                } else {
                    $('#node-tip').hide();
                }

dceejay · 29 January 2022 00:37

I guess it would make sense for that to be prioritised the other way round, so it uses he name if set, and if not then the to field, and finally just the word "email".

Though looking at the code it's more mixed up than that... so untangling it would potentially break users - not to be undertaken lightly...

daxliniere · 29 January 2022 00:57

Ahh, I see.

Yes, agree 100%.

That's a shame.

No worries, it's not a huge big deal, just something I spotted and thought I should report.

Cheers, guys!
Dax.

system · 30 March 2022 00:57

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
FR: Use default node name for debug when name not specified Feature Requests	6	523	28 March 2022
Auto-Name Debug Node with some serialization, with an option to override the name Feature Requests	3	496	17 January 2022
Possible debug node status bug General	4	454	29 January 2019
Disable auto numbering scheme for UI components? General	13	166	9 April 2023
Debug node suggestion Feature Requests	14	615	19 September 2021

BUG: Email node doesn't use node name for debug message

Related Topics