Question: About jshint:editor of grunt

okhiroyuki · 17 January 2020 23:40

Hello.
I have a question.

grunt's jshint:editor seems to look at the old folder structure.

node-red/node-red/blob/ee6f6ae39106350d9d1552409407bc2e62362554/Gruntfile.js#L102


            'red.js',
            'packages/**/*.js',
        ]
    }
},
nodes: {
    files: {
        src: [ 'nodes/core/*/*.js' ]
    }
},
editor: {
    files: {
        src: [ 'editor/js/**/*.js' ]
    }
},
tests: {
    files: {
        src: ['test/**/*.js']
    },
    options: {
        "expr": true

There are other similar issues, but I especially focused on jshint:editor because of the default grunt task.

Is this a known issue?

knolleary · 17 January 2020 23:52

Hi

I was aware the jshint task had stopped working on the editor files, but hadn't got around to looking at why. You are quite right - looks like the jshint:editor task does need updating to packages/node_modules/@node-red/editor-client/src/js/**/*.js.

With that in place, the task then does find a small number of linting issues that have crept in. Nothing serious, but they need tidying up. Let me know if you want to take a look at them, otherwise I'll add it to my todo list.

okhiroyuki · 18 January 2020 00:03

It's not serious at all, so I'm glad it will be fixed in the future.
Thank you very much.

Topic		Replies	Views
Using grunt when contributing Core Development	6	636	30 June 2020
Build @node-red/editor-client General	4	268	24 August 2021
About making @node-red/editor-client module based (with typings one day) Core Development editor	11	403	10 September 2022
Full node appearance General	9	794	30 October 2019
[Announce] node-red-contrib-uibuilder - v1.1.0-beta8 (alternate adminui-editor branch) Share Your Nodes	3	733	10 February 2019

Question: About jshint:editor of grunt

Related Topics