Bug report: trigger node not passing the correct msg object

techraf · 23 February 2020 14:21

Hi, I'm not sure where is best to post this.

The trigger node set to send the latest msg object is not passing the latest msg object, but the first msg object with only the payload value replaced.

Here's what it looks like:

The trigger node settings:

I am expecting the debug Passed message to be equal to Message 2.
Instead, it is a mix of Message 1 and Message 2 msg-object contents.

The code to reproduce (Node-RED 1.0.3: Maintenance Release):

[{"id":"42c29b08.2b2784","type":"trigger","z":"d8fc40a5.f4ce2","op1":"","op2":"","op1type":"nul","op2type":"payl","duration":"5","extend":false,"units":"s","reset":"","bytopic":"all","name":"","x":520,"y":180,"wires":[["a954ede4.92d5c"]]},{"id":"a954ede4.92d5c","type":"debug","z":"d8fc40a5.f4ce2","name":"Passed message","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":710,"y":180,"wires":[]},{"id":"d04c3e77.e42ea","type":"debug","z":"d8fc40a5.f4ce2","name":"Message 1","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":530,"y":100,"wires":[]},{"id":"52a161c1.2c784","type":"inject","z":"d8fc40a5.f4ce2","name":"","topic":"","payload":"","payloadType":"date","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":180,"y":140,"wires":[["6d25d2f1.25824c","73970088.564fb"]]},{"id":"73970088.564fb","type":"change","z":"d8fc40a5.f4ce2","name":"Set 1","rules":[{"t":"set","p":"payload","pt":"msg","to":"Payload of message 1","tot":"str"},{"t":"set","p":"key1","pt":"msg","to":"Value from message 1","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":350,"y":140,"wires":[["42c29b08.2b2784","d04c3e77.e42ea"]]},{"id":"173de41.89eb21c","type":"change","z":"d8fc40a5.f4ce2","name":"Set 2","rules":[{"t":"set","p":"payload","pt":"msg","to":"Payload of message 2","tot":"str"},{"t":"set","p":"key2","pt":"msg","to":"Value from message 2","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":350,"y":220,"wires":[["42c29b08.2b2784","7116a57.075b05c"]]},{"id":"6d25d2f1.25824c","type":"delay","z":"d8fc40a5.f4ce2","name":"","pauseType":"delay","timeout":"2","timeoutUnits":"seconds","rate":"1","nbRateUnits":"1","rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"x":200,"y":220,"wires":[["173de41.89eb21c"]]},{"id":"7116a57.075b05c","type":"debug","z":"d8fc40a5.f4ce2","name":"Message 2","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":530,"y":260,"wires":[]}]

This looks as a bug to me. Am I wrong?

Colin · 23 February 2020 16:04

Confirming that I see the same symptom.
Node-RED version: v1.0.3
Node.js version: v12.16.1

Trying_to_learn · 23 February 2020 20:20

I too shall concur.

NR 1.0.3
node 10.18.1

Trying_to_learn · 23 February 2020 20:21

Hi.

It's nice to see I am not the only one who plays around the limits of the program.

Don't be afraid to ask if you don't understand something.
It is only when you try these sorts of things do you find problems/bugs/etc.

Colin · 24 February 2020 09:16

@dceejay is this a bug?

dceejay · 24 February 2020 17:17

Indeed - please raise an issue...

techraf · 24 February 2020 18:20

Sorry, but I'm fairly new to Node-RED and did not figure out yet how it is maintained.

Which repo includes built-in (?) nodes?

dceejay · 24 February 2020 19:00

The core nodes are in the main repo https://github.com/node-red/node-red/issues

Trying_to_learn · 25 February 2020 21:48

ONLY for the sake of curiosity, where on the local machine is the code for the node?

Is it like the other nodes or is it in a bigger package?

I've tried finding it but to no avail.

bakman2 · 26 February 2020 05:47

try
find / -name 89-trigger.js 2>/dev/null

on my system:
/usr/lib/node_modules/node-red/node_modules/@node-red/nodes/core/function/89-trigger.js

Trying_to_learn · 26 February 2020 05:48

I didn't know it was actually called 89-trigger.

Thanks.

bakman2 · 26 February 2020 05:50

The filenames are in the repository

github.com

node-red/node-red/blob/master/packages/node_modules/@node-red/nodes/core/function/89-trigger.js

/**
 * Copyright JS Foundation and other contributors, http://js.foundation
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 **/

module.exports = function(RED) {
    "use strict";
    var mustache = require("mustache");
    function TriggerNode(n) {

This file has been truncated. show original

Trying_to_learn · 26 February 2020 05:51

Yeah, ok.

But that is unexplored land for me. I'll have a butcher's hook at the code when I get time.

I'm not good with the github repository.

bakman2 · 26 February 2020 05:54

It is surely valuable time spend, if you click the history button for that file, you can see that @dceejay already made changes to the code

Trying_to_learn · 26 February 2020 05:55

Please,

I am not trying to shame anyone. I am just curious to see the code with the problem and see if I can nut it out myself.

Though I will update the node to the newer version all the same.

techraf · 26 February 2020 09:16

Small hint: while browsing the GitHub repo, you can press t on your keyboard and enter a filename (or a part of) -- it will show you matching files.

techraf · 26 February 2020 09:19

What is the meaning of the numbers preceeding the nodes' names?

Is it some kind of prioritization?

dceejay · 26 February 2020 11:42

it's ancient history

knolleary · 26 February 2020 12:42

Not so much ancient history, rather a key way we are able to control what order the nodes appear in the palette.

Trying_to_learn · 26 February 2020 21:04

Ok, next dumb question from me.

Ok. But when I go to the palette manager there is no update to the trigger node.

Sorry if I am even dumber than I usually am. There are a few things going on which are really not helping me.

Topic		Replies	Views
Trigger Node - Original versus Latest then Send option General	11	460	31 May 2022
Trigger node - unexpected behaviour with "then send" "the original msg object" General	8	141	17 February 2023
Questions about Payload of trigger node General	6	366	13 December 2019
Msg.payload undefined while msg : Object is working - help! General	3	155	29 May 2023
Msg root to file General	10	485	17 October 2018

Bug report: trigger node not passing the correct msg object

Related Topics