Continuing the discussion from Some nodes not showing in 'Manage palette' :
I stumbled - once again - over the fact that a plugin without nodes isn't shown in the Palette Manager; thus, despite the plugin can be installed , it can neither be updated nor removed via this mean.
Would you accept a PR that adds this functionality?
Hi @ralphwetzel
Can I suggest you raise an issue and signal your intent to raise a PR.
Please include an outline of your proposal for discussion.
Also, please include links back to topics of discussion too.
I will be sure to keep an eye out and respond if necessary.
@Steve-Mcl
Will do; should the PR raised against dev
or the main
branch?
Update: Issue report is now established.
1 Like
New features against dev please.
1 Like
system
Closed
9 October 2023 20:04
5
This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.
Progress update: PR is (finally) placed!
node-red:dev
ā ralphwetzel:dev_plugin
opened 06:15AM - 18 Oct 23 UTC
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-ā¦ breaking change which adds functionality)
## Proposed changes
This PR adds support for plugin-only modules to the palette manager. Closes #4271.
<img width="527" alt="image" src="https://github.com/node-red/node-red/assets/16342003/f99bda9e-0187-4a8d-9697-ea329ccb4a7d">
## Checklist
- [x] I have read the [contribution guidelines](https://github.com/node-red/node-red/blob/master/CONTRIBUTING.md)
- [x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
- [x] I have run `npm run test` to verify the unit tests pass
- [ ] I have added suitable unit tests to cover the new/changed functionality
## Details of implementation
Runtime:
- New runtime-event 'plugin/added', emitted only if a pure plugin module is installed.
Editor API:
- New endpoint '/plugins/<id>' to query for the config of a single plugin.
- Function 'getConfig' to return the config of a single plugin.
editor.json / runtime.json:
- Plugin specific messages.
Editor Client:
- New functions for plugin (registry) handling, following nodes schematic: setPluginList/addPlugin, getModule.
- New event "registry:plugin-module-added", signaling a (plugin) module was registered w/ addPlugin.
- New event subscription "notification/plugin/added", to query the added plugins config from the runtime (following nodes schematic).
Palette Editor (Client):
- Handler for "registry:plugin-module-added" to add plugin data to the various lists.
- Dedicated list management when adding & removing a plugin.
- Support for **new function "onremove", defined by the plugin (html), to remove itself from the client**.
Installer (runtime)
- In uninstallModule, remove plugin config from (plugin) registry.
- Log info in case of plugin removal.
Registry (runtime) / plugin
- New function to get the config of a single plugin.
- New function to remove the config of a single plugin.
- Support for **new function "onremove", defined by the plugin (js), to remove itself from the runtime**.
Registry (runtime)
- Adapt moduleInfo to handle as well plugins.
7 Likes