Node-red-node-aws: html form state bucket is required which prevent providing from msg

Barbudor · 24 November 2022 09:45

Hi

The AWS nodes "Amazon S3" and Amazon S3 out" can support a bucket name provided as the msg.bucket property. It works fine but as the form specify that the bucket field in the form is required, a warning is generated on each deploy.

I propose a PR to change those 2 descriptors from:

            bucket: {required:true},

to

            bucket: {value:""},

in

github.com

node-red/node-red-web-nodes/blob/52cdc1bb29ed8757295300371912ef9ff5a84a44/aws/aws.html#L129


      
                  <input type="text" id="node-input-name" data-i18n="[placeholder]aws.placeholder.name">
              </div>
          </script>
          
          
<script type="text/javascript">
              RED.nodes.registerType('amazon s3',{
                  category: 'storage-output',
                  color:"#C0DEED",
                  defaults: {
                      aws: {type:"aws-config",required:true},
                      bucket: {required:true},
                      filename: {value:""},
                      region: {value:"", required:true},
                      name: {value:""},
                  },
                  inputs:1,
                  outputs:1,
                  icon: "amazon.png",
                  align: "right",
                  label: function() {
                      return this.bucket ? "s3 "+this.bucket : "s3";

and

github.com

node-red/node-red-web-nodes/blob/52cdc1bb29ed8757295300371912ef9ff5a84a44/aws/aws.html#L66


      
                  <input type="text" id="node-input-name" data-i18n="[placeholder]aws.placeholder.name">
              </div>
          </script>
          
          
<script type="text/javascript">
              RED.nodes.registerType('amazon s3 in',{
                  category: 'storage-input',
                  color:"#C0DEED",
                  defaults: {
                      aws: {type:"aws-config",required:true},
                      bucket: {required:true},
                      region: {value:"", required:true},
                      filepattern: {value:""},
                      name: {value:""},
                  },
                  inputs:0,
                  outputs:1,
                  icon: "amazon.png",
                  label: function() {
                      return this.bucket ? "s3 "+this.bucket : "s3";
                  }

I'm ready to send the PR if you are ok

Just for your reference, the JS code is perfectly handling that:

github.com

node-red/node-red-web-nodes/blob/52cdc1bb29ed8757295300371912ef9ff5a84a44/aws/aws.js#L162


      
          this.filename = n.filename || "";
          var node = this;
          var AWS = this.awsConfig ? this.awsConfig.AWS : null;
          
          
if (!AWS) {
              node.warn(RED._("aws.warn.missing-credentials"));
              return;
          }
          var s3 = new AWS.S3({"region": node.region});
          node.on("input", function(msg) {
              var bucket = node.bucket || msg.bucket;
              if (bucket === "") {
                  node.error(RED._("aws.error.no-bucket-specified"),msg);
                  return;
              }
              var filename = node.filename || msg.filename;
              if (filename === "") {
                  node.warn("No filename");
                  node.error(RED._("aws.error.no-filename-specified"),msg);
                  return;
              }

and

github.com

node-red/node-red-web-nodes/blob/52cdc1bb29ed8757295300371912ef9ff5a84a44/aws/aws.js#L220


      
          node.status({fill:"blue",shape:"dot",text:"aws.status.checking-credentials"});
          s3.listObjects({ Bucket: node.bucket }, function(err) {
              if (err) {
                  node.warn(err);
                  node.error(RED._("aws.error.aws-s3-error",{err:err}));
                  node.status({fill:"red",shape:"ring",text:"aws.status.error"});
                  return;
              }
              node.status({});
              node.on("input", function(msg) {
                  var bucket = node.bucket || msg.bucket;
                  if (bucket === "") {
                      node.error(RED._("aws.error.no-bucket-specified"),msg);
                      return;
                  }
                  var filename = node.filename || msg.filename;
                  if (filename === "") {
                      node.error(RED._("aws.error.no-filename-specified"),msg);
                      return;
                  }
                  var localFilename = node.localFilename || msg.localFilename;

Thanks

dceejay · 24 November 2022 10:12

yes - please raise a PR.

Barbudor · 24 November 2022 11:11

Thanks @dceejay
Done AWS - bucket not required in form for s3query and s3out by jeanmichel-nwsb · Pull Request #303 · node-red/node-red-web-nodes · GitHub

Best regards

dceejay · 24 November 2022 11:29

Published as v0.2.3. Thanks

Barbudor · 24 November 2022 12:28

Thanks a lot

system · 23 January 2023 12:29

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
SQS DeleteMessage - ReceiptHandleIsInvalid - Node-red-contrib-aws General	3	405	2 October 2021
[NEW FEATURE] node-red-contrib-simple-gate (version 0.3.0) Share Your Nodes	1	403	4 June 2020
Offcial AWS ElasticBeansTalk Tutorial not working General	3	368	20 May 2021
Message: Please migrate your code to use AWS SDK for JavaScript (v3) General	0	47	22 April 2024
[NEW NODE] node-red-contrib-primitive-status Share Your Nodes	13	528	24 October 2021

Node-red-node-aws: html form state bucket is required which prevent providing from msg

Related Topics