Trouble with javascript

[Thewaver]

Hi, trying to change msg.payload from true to on and false to off from the alexa node. Used a function node with the following but it doesnt work, can anyone tell me why.??

if (msg.payload == "true"){
msg.payload = "on";
}
else if (msg.payload == "false"){
msg.payload = "off";
}
return msg;

[JGKK]

if its a typeof boolean true and false you need to do the comparison without the “”,so:

if (msg.payload == true) {

otherwise your looking for the literal strings of true and false.
You can see which it is when you connect a debug to the previous node and check in the debug tab for the format of this message property.
Johannes
Ps: and a happy forum anniversary

[E1cid]

or

msg.payload = (msg.payload == true) ? "on" : "off";

[Colin]

or even

msg.payload = msg.payload ? "on" : "off"

You don't need to test msg.payload == true as it is itself true (or false).

[E1cid]

That all depends on whether you wish ON when the payload is {}.

[Thewaver]

Problem solved. Thank you to everyone who helped, very much appreciated.

[Colin]

@E1cid

That all depends on whether you wish ON when the payload is {}

If you want to test for exactly true rather than just truthy then you should use ===. With == you will see a yellow warning triangle in the editor.

[E1cid]

As i said it depends what you require.