Issue in node-red-contrib-zwave-js 6.3.0 / event-filter node

General
1

Hello,
at first, many thanks for this great node for managing a zwave network!

I have migrated form openwave to zwave js and realy appreciate the new performance and also the capability to manage ZW network directly form NR UI !
However i found an issue on how the event filter node works. I need to do a strict filter by check "strict" flag in a rule but this change nothing about the event filter node behavior, endpoint value is never taken into account. I tooke a look in the code and made a correction into. The corrected code is attached (see at lines 39, 91, 96, 104 and 117).
Hope this is correct :slight_smile:event-filter.js.txt (2.7 KB)

1 Like
2

@Francky

Many thanks for looking at this.
I will review shortly and look to implement the fix in my 6.4.0 branch.

once again - thank you

3

@Francky

Nice!

didn't spot that - asking for strict on the nodes config as apposed to the rule.
I am working on 6.4.0, so will get this fix in there - Once again Thank you.

I am waiting for a replacement dev computer (i pushed the old one to its limit)
once its here, I'll release 6.4.0. :+1:

4

Perfect !
Having strict parameter per rule is realy the better solution !
Have fun with your new PC :wink:
Thank you for this futur release :slight_smile:

5

Yup, the strict flag is designed per rule, but for some crazy reason, I was trying to get at it, on the config object. :man_shrugging:

6

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.